Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_statement_import_file_reconcile_oca #697

Merged

Conversation

mpascuall
Copy link

Module migrated to version 17.0

cc https://github.com/APSL 155420

@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 please review

alexis-via and others added 9 commits May 22, 2024 08:34
The module was ported from v14. It was renamed from
account_statement_import_file_reconciliation_widget to
account_statement_import_file_reconcile_oca to take into account the new
names of the modules it depend on.

Update code to the new notification system.
Currently translated at 100.0% (2 of 2 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file_reconcile_oca/es/
Currently translated at 100.0% (2 of 2 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_file_reconcile_oca
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_file_reconcile_oca/it/
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality in Runboat

@HaraldPanten
Copy link
Contributor

/ocabot migration account_statement_import_file_reconcile_oca

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 20, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 20, 2024
10 tasks
Copy link

@Tisho99 Tisho99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Functional and code review

@Tisho99
Copy link

Tisho99 commented Jun 21, 2024

@HaraldPanten

@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-697-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7bc319a into OCA:17.0 Jun 21, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 028c29b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants