-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of read-in for general plot settings #27
base: main
Are you sure you want to change the base?
Conversation
…option and figure size) for all plot options (--plotconfig and --plot/--plotall)
…lor/colormap, corrected default behaviors if no plot-settings are chosen when calling --plot/plotall
…ched to hexbins for 2D-histograms because they look better. Adjustments for show-plot still needed!
Okay I've gotten a chance to look into these commits. They're mostly good work, and do implement the job you hoped to do. There are however 2 high-level issues that I have with this, both of which suggest a rework.
Otherwise, the lower-level details are good. I like what you've done with the matplotlib hexbin methods, and applaud your use of black, and flake8 in these commits 👏. Proposed solution: Let's refactor and create a separate plotting class or a closure function that consolidates this responsibility in a single logical entity. Then we'll rework the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
Yes, I think you're completely right! Thinking about it a bit the last two weeks, especially with regard to making even more plots available, the current implementation is too repetitive. |
…ated with nuSpaceSim
I am not sure if this is anywhere close to what you had in mind and it might need some more work. Please let me know what you think and I can make changes! |
…ith --plot. Changed default settings back to viridis. Fixed calculation of binwidth (was producing negative values)
I made some changes to default values and added the --plotsettings flag that can be used when making plots with --plot instead of --plotconfig. There was also an issue with the binwidth being negativ when plotting profiles that is now fixed. |
Here is the implementation I came up with to read-in general plot settings, such as filename, file extension, or figure size. It should work for all available methods to plot via command line (--plotconfig and --plot/--plotall). For --plotconfig the read in is automatic, for --plot/--plotall the settings have to be submitted via --plotsettings.