Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose query api to typescript #761

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Expose query api to typescript #761

merged 3 commits into from
Feb 22, 2024

Conversation

AntonyBlakey
Copy link
Contributor

No description provided.

@AntonyBlakey AntonyBlakey requested a review from a team as a code owner February 1, 2024 12:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6b501e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AntonyBlakey AntonyBlakey self-assigned this Feb 1, 2024
@AntonyBlakey AntonyBlakey marked this pull request as draft February 1, 2024 12:02
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/expose-query-api-to-typescript branch 3 times, most recently from e01f985 to 9ecdb13 Compare February 4, 2024 11:48
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/expose-query-api-to-typescript branch 3 times, most recently from 448b6d7 to 4eb2cad Compare February 14, 2024 14:56
@AntonyBlakey AntonyBlakey marked this pull request as ready for review February 14, 2024 14:58
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/expose-query-api-to-typescript branch from 4eb2cad to 30b1147 Compare February 16, 2024 14:49
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/expose-query-api-to-typescript branch 2 times, most recently from 9188187 to 7e821c8 Compare February 22, 2024 02:13
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/expose-query-api-to-typescript branch from 7e821c8 to fe6913f Compare February 22, 2024 10:10
OmarTawfik
OmarTawfik requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions/suggestions. Thanks!

@OmarTawfik OmarTawfik mentioned this pull request Feb 22, 2024
Open
OmarTawfik
OmarTawfik approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one suggestion open.

@AntonyBlakey AntonyBlakey added this pull request to the merge queue Feb 22, 2024
Merged via the queue into NomicFoundation:main with commit 8a93ce8 Feb 22, 2024
1 check passed
@AntonyBlakey AntonyBlakey deleted the AntonyBlakey/expose-query-api-to-typescript branch February 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

Assignees

@AntonyBlakey AntonyBlakey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AntonyBlakey @OmarTawfik