Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"function call to a non-contract account" heuristic should include the address #3870

Conversation

ZainGulbaz
Copy link

1- The pull request includes the improvement.

There is the improvement in the error message that is shown when a non contract account function is called.
Previous Message:
Transaction reverted: function call to a non-contract account
Improved Message:
Transaction reverted: function call to a non-contract account 0x009fd6e51aa188f6f4ce6ab8827279cfffb92200

The PR is related to #3771

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

⚠️ No Changeset found

Latest commit: 9343035

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 7:26pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 7:26pm

@alcuadrado
Copy link
Member

Sorry we never got to merge this. Unfortuantely the code has changed so much that it can't be merged now.

@alcuadrado alcuadrado closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants