Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when URL is empty string #3828

Closed
wants to merge 1 commit into from
Closed

Improve error message when URL is empty string #3828

wants to merge 1 commit into from

Conversation

MarioRodrigues10
Copy link

@MarioRodrigues10 MarioRodrigues10 commented Apr 8, 2023

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR was created in order to solve #2730

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2023

⚠️ No Changeset found

Latest commit: b8a9bcb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 8:56pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 8:56pm

@fvictorio
Copy link
Member

Hi @MarioRodrigues10, I doubt this PR does what you think it does. The issue is about showing a better error in certain scenarios, and related to how we validate the config. This is changing the value used in a comparison (and it probably introduces a bug).

@fvictorio fvictorio closed this Apr 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants