chore: improve sentry sampling #570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample most traces as before (1 in development, 0.001 in production), but exclude the `indexing` trace, which won't be sampled. Indexing happens once per session, and is being used to provide feature flag information. That info is significantly less useful if it is sampled.
OmarTawfik
reviewed
Jun 10, 2024
| Sentry.init({ | ||
| dsn: this.dsn, | ||
| tracesSampleRate: serverState.env === "development" ? 1 : 0.001, | ||
| tracesSampler: ({ transactionContext: { name } }) => { | ||
| if (name === "indexing") { |
There was a problem hiding this comment.
Nit suggestion:
I see we are using the raw indexing value in a few places already. I suggest exporting/reusing INDEXING_JOB_ID everywhere so that they don't go out of sync.
OmarTawfik
reviewed
Jun 10, 2024
| Sentry.init({ | ||
| dsn: this.dsn, | ||
| tracesSampleRate: serverState.env === "development" ? 1 : 0.001, | ||
| tracesSampler: ({ transactionContext: { name } }) => { |
There was a problem hiding this comment.
this means we will no longer have sampling for both the user platform AND the 2 features flag status (as they are recorded within indexing). Is that correct?
There was a problem hiding this comment.
Yes. The indexing event won't be sampled, as the feature flag status is recorded into this event, neither will the feature flag tags.
Put another way sampling will no longer obscure the indexing based recording of feature flags.
OmarTawfik
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample most traces as before (1 in development, 0.001 in production), but exclude the
indexingtrace, which won't be sampled.Indexing happens once per session, and is being used to provide feature flag information. That info is significantly less useful if it is sampled.
The fine grained control is provided by swapping from a trace sampling rate to a trace sampling function, as described here: https://docs.sentry.io/platforms/javascript/guides/capacitor/configuration/sampling/#setting-a-sampling-function