nixos/stalwart-mail: add module-local stateVersion option #321873
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `services.stalwart-mail.stateVersion` option allowing the consumer to choose which defaults to use for this module. This is desirable for those wishing to use the new defaults before the next release, and eases state migration for just this module. This follows the discussion at NixOS#315908 (comment)
|
After longer thinking about your response on my suggestion is agree with you that we should not add a local state version. The main problem on the old code on my opinion was, that is was a very bad UX in override to state logic and bootstrapping logic of the state dir (which is still a topic on my opinion when someone wants to move that), let's improve on that UX and try to avoid additional states. Choosing defaults based on the nixos State version is the right approach, and adding more state is possibly not the best idea I had :) Let me think some days over how I would try to increase that UX without adding more state Version and not over complicating the modules logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds a
services.stalwart-mail.stateVersionoption allowing theconsumer to choose which defaults to use for this module. This is
desirable for those wishing to use the new defaults before the next
release, and eases state migration for just this module.
This follows the discussion at
#315908 (comment)
CC: @Shawn8901
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.