Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rnote: mark as broken on darwin #314292

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented May 24, 2024

Description of changes

ZHF: #309482

Related: #311905

Rnote fails to build on darwin: https://hydra.nixos.org/build/260530724

Feel free to fix it if you can, I don't have and I don't know darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@gepbird gepbird added 0.kind: ZHF Fixes Fixes during the ZHF campaign backport release-24.05 Backport PR automatically labels May 24, 2024
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels May 24, 2024
@nbraud nbraud merged commit bc62c50 into NixOS:master May 25, 2024
30 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

@gepbird gepbird deleted the rnote-mark-broken-darwin branch May 25, 2024 08:07
Sobte pushed a commit to Sobte/nixpkgs that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants