Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.graph-tool: 2.45 -> 2.65 #314037

Merged
merged 2 commits into from
May 25, 2024
Merged

python3Packages.graph-tool: 2.45 -> 2.65 #314037

merged 2 commits into from
May 25, 2024

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented May 23, 2024 •
edited by mweinelt

Description of changes

fix build (https://hydra.nixos.org/build/260944696)

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Moraxyc Moraxyc changed the title pythonPackages.graph-tool: 2.45 -> 2.65 python3Packages.graph-tool: 2.45 -> 2.65 May 23, 2024
@Moraxyc Moraxyc marked this pull request as ready for review May 23, 2024 17:48
@Moraxyc Moraxyc added 0.kind: ZHF Fixes Fixes during the ZHF campaign backport release-24.05 Backport PR automatically labels May 23, 2024
@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 25, 2024 •
edited

I have no idea how to fix build on Darwin...

It seems impossible to build Darwin package on linux.

@Moraxyc Moraxyc requested a review from mweinelt May 25, 2024 02:49
@mweinelt
Copy link
Member

mweinelt commented May 25, 2024 •
edited

Please set meta.broken = stdenv.isDarwin in another commit. It fails the same as on 2.45, and I don't have a good idea what is wrong.

@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 25, 2024

@ofborg build python3Packages.graph-tool

@mweinelt mweinelt merged commit 10639a4 into NixOS:master May 25, 2024
8 of 13 checks passed
@Moraxyc Moraxyc deleted the graph-tool branch May 25, 2024 10:46
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 25, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0 backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Moraxyc @mweinelt