Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.aiosasl: fix broken tests on Python 3.12 #313944

Merged
merged 3 commits into from
May 23, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 23, 2024

Description of changes

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@fabaff fabaff added 0.kind: ZHF Fixes Fixes during the ZHF campaign backport release-24.05 Backport PR automatically labels May 23, 2024
@fabaff
Copy link
Member Author

fabaff commented May 23, 2024

Result of nixpkgs-review pr 313944 run on x86_64-linux 1

10 packages built:
  • moodle-dl
  • moodle-dl.dist
  • python311Packages.aiosasl
  • python311Packages.aiosasl.dist
  • python311Packages.aioxmpp
  • python311Packages.aioxmpp.dist
  • python312Packages.aiosasl
  • python312Packages.aiosasl.dist
  • python312Packages.aioxmpp
  • python312Packages.aioxmpp.dist

@ofborg ofborg bot requested a review from dotlambda May 23, 2024 10:46
@fabaff fabaff merged commit fc538a5 into NixOS:master May 23, 2024
25 of 26 checks passed
@fabaff fabaff deleted the aiosasl-fix branch May 23, 2024 19:42
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant