pidgin: fix build on darwin, add mainProgram #310923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
pkgs/applications/networking/instant-messengers/pidgin/default.nix
Outdated
Show resolved
Hide resolved
ghost
reviewed
May 11, 2024
There was a problem hiding this comment.
the diff below fixes the clang build. (tested on x64 darwin). can probably also test using pkgsLLVM.pidgin on linux, but that needs to build a bunch of stuff so i didn't try.
ignore clang error.diff
diff --git a/pkgs/applications/networking/instant-messengers/pidgin/default.nix b/pkgs/applications/networking/instant-messengers/pidgin/default.nix
index 211c5b49bf9a..4274935caf5f 100644
--- a/pkgs/applications/networking/instant-messengers/pidgin/default.nix
+++ b/pkgs/applications/networking/instant-messengers/pidgin/default.nix
@@ -107,7 +107,8 @@ let
]
++ lib.optionals withCyrus_sasl [ "--enable-cyrus-sasl=yes" ]
++ lib.optionals withGnutls [ "--enable-gnutls=yes" "--enable-nss=no" ]
- ++ lib.optionals stdenv.isDarwin [ "--disable-gtkspell" "--disable-vv" ];
+ ++ lib.optionals stdenv.isDarwin [ "--disable-gtkspell" "--disable-vv" ]
+ ++ lib.optionals stdenv.cc.isClang [ "CFLAGS=-Wno-error=int-conversion" ];
enableParallelBuilding = true;
Signed-off-by: lucasew <[email protected]>
lucasew
force-pushed
the
20240511-pidgin-broken-darwin
branch
from
8fab934
to
c4b50d2
Compare
lucasew
changed the title
I applied that change. Can you run nixpkgs-review on this PR? |
|
@ofborg build pidgin |
|
Result of |
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 0
labels
|
Result of 1 package marked as broken and skipped:
1 package failed to build:
2 packages built:
|
ghost
approved these changes
May 12, 2024
There was a problem hiding this comment.
Result of nixpkgs-review pr 310923 run on x86_64-darwin 1
1 package marked as broken and skipped:
- pidginPackages.tdlib-purple
1 package failed to build:
- telepathy-haze
2 packages built:
- pidgin (pidginPackages.pidgin)
- pidginPackages.purple-matrix
telepathy-haze fails due to unrelated compile error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I don't have anything darwin here and I am the only maintainer of pidgin.
ZHF #309482
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.