Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pytest-{fixture-config,shutil,server-fixtures,virtualenv}: * -> 1.7.1-unstable-2022-10-03 #310905

Merged
merged 4 commits into from May 12, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented May 11, 2024

Description of changes

ZHF: #309482

Some packages were failing, because they tried to import common_setup from a directory that doesn't exist. I could solve this by fetching from the GitHub repo instead.
I used the latest commit, because that has the most fixes applied to it.
To not repeat myself, I only used fetchFromGitHub in pytest-fixture-config and in all other packages I just inherited the version and src values.

Changes done to all packages:

  • use pyproject = true
  • move dependencies around

Changes done to pytest-shutil

  • remove unused check-time dep
  • add patch fixing the build on newer python versions

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 11, 2024
@TomaSajt TomaSajt marked this pull request as draft May 11, 2024 19:48
@TomaSajt TomaSajt marked this pull request as ready for review May 12, 2024 07:59
@pluiedev
Copy link
Contributor

Result of nixpkgs-review pr 310905 run on x86_64-linux 1

12 packages failed to build:
  • python311Packages.pytest-server-fixtures
  • python311Packages.pytest-server-fixtures.dist
  • python311Packages.pytest-virtualenv
  • python311Packages.pytest-virtualenv.dist
  • python311Packages.ramlfications
  • python311Packages.ramlfications.dist
  • python312Packages.pytest-server-fixtures
  • python312Packages.pytest-server-fixtures.dist
  • python312Packages.pytest-virtualenv
  • python312Packages.pytest-virtualenv.dist
  • python312Packages.ramlfications
  • python312Packages.ramlfications.dist
4 packages built:
  • python311Packages.pytest-shutil
  • python311Packages.pytest-shutil.dist
  • python312Packages.pytest-shutil
  • python312Packages.pytest-shutil.dist

@TomaSajt TomaSajt marked this pull request as draft May 12, 2024 14:18
@TomaSajt TomaSajt changed the title python312Packages.pytest-shutil: add patch, clean up python312Packages.pytest-{fixture-config,shutil,server-fixtures,virtualenv}: * -> 1.7.1-unstable-2022-10-03 May 12, 2024
@TomaSajt TomaSajt marked this pull request as ready for review May 12, 2024 14:50
@wegank
Copy link
Member

wegank commented May 12, 2024

Result of nixpkgs-review pr 310905 run on aarch64-darwin 1

20 packages built:
  • python311Packages.pytest-fixture-config
  • python311Packages.pytest-fixture-config.dist
  • python311Packages.pytest-server-fixtures
  • python311Packages.pytest-server-fixtures.dist
  • python311Packages.pytest-shutil
  • python311Packages.pytest-shutil.dist
  • python311Packages.pytest-virtualenv
  • python311Packages.pytest-virtualenv.dist
  • python311Packages.ramlfications
  • python311Packages.ramlfications.dist
  • python312Packages.pytest-fixture-config
  • python312Packages.pytest-fixture-config.dist
  • python312Packages.pytest-server-fixtures
  • python312Packages.pytest-server-fixtures.dist
  • python312Packages.pytest-shutil
  • python312Packages.pytest-shutil.dist
  • python312Packages.pytest-virtualenv
  • python312Packages.pytest-virtualenv.dist
  • python312Packages.ramlfications
  • python312Packages.ramlfications.dist

@wegank wegank merged commit 27713bd into NixOS:master May 12, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants