Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwebbin: -std=c++14 due to register keyword #309803

Merged
merged 1 commit into from
May 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 7, 2024

companion to #309749 (comment). now that tie is fixed fix cwebbin.

  • fix build with clang
  • refactor to use default buildPhase and installPhase

ZHF: #309482

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

- fix build with clang
- refactor to use default buildPhase and installPhase
@ghost
Copy link
Author

ghost commented May 7, 2024

Result of nixpkgs-review run on x86_64-darwin 1

2 packages built:
  • cwebbin
  • edit

@wegank
Copy link
Member

wegank commented May 7, 2024

Result of nixpkgs-review pr 309803 run on aarch64-darwin 1

2 packages built:
  • cwebbin
  • edit

@wegank wegank merged commit 7a19608 into NixOS:master May 7, 2024
25 of 26 checks passed
@ghost ghost deleted the cwebbin-fix branch May 7, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant