lightningcss: 1.24.0 -> 1.24.1 #302174
Merged
lightningcss: 1.24.0 -> 1.24.1 #302174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally patch ./napi/Cargo.toml to allow building lightningcss-napi parcel-bundler/lightningcss#713 parcel-bundler/lightningcss#702
1 task
|
Looks good, but I will need to test in the morning. Thanks since I have no Rust experience. Now if only your genius could fix the system color regression. :)
--
toastal ไข่ดาว | https://toast.al
PGP: 7944 74b7 d236 dab9 c9ef e7f9 5cce 6f14 66d4 7c9e
|
|
Result of 1 package built:
|
Gerg-L
approved these changes
Apr 6, 2024
toastal
approved these changes
Apr 7, 2024
Patch is made to the build instructions (Cargo.toml), no change has been made to the codebase. Upstream maintainer simply did not test the build on cargo auditable carefully. |
|
@toastal Would you be okay with me co-maintaining this package with you? I will add myself as a maintainer if you are okay with it. |
wegank
added
12.approvals: 2
12.approved-by: package-maintainer
and removed
12.approvals: 1
labels
|
Absolutely!
--
toastal ไข่ดาว | https://toast.al
PGP: 7944 74b7 d236 dab9 c9ef e7f9 5cce 6f14 66d4 7c9e
|
2 tasks
|
While trying to cross-compile for aarch64: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
lightningcss: 1.24.0 -> 1.24.1 - Changelog
Additionally patch ./napi/Cargo.toml to allow building lightningcss-napi. See parcel-bundler/lightningcss#713 parcel-bundler/lightningcss#702.
Without this patch, v1.24.1 won't build at all since an entire dependency napi was added in this release.
Closes #296639.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Pinging maintainer: @toastal
Add a 👍 reaction to pull requests you find important.