Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Astro rework) Redesign of /community page and its subpages #1160

Merged
merged 59 commits into from
Dec 17, 2023
Merged

(Astro rework) Redesign of /community page and its subpages #1160

merged 59 commits into from
Dec 17, 2023

Conversation

kacperwyczawski
Copy link
Contributor

@kacperwyczawski kacperwyczawski commented Nov 21, 2023

Changes:

  • migrate /community, /community/[team], /community/event-funding and /community/commercial-support to Astro
  • update DaisyUI to 4.0.4 for timeline support
  • animate RFC diagram
  • load content from content collections (22 new .yaml or .mdx files)
  • introduce MDXLayout for creating pages in mdx
  • translate content from html to mdx/yaml
  • use Fisher-Yates algorithm for unbiased shuffle in commercial support page
  • add members of nixcon team, based on this post
  • add contact section to team pages
  • update link for adding company to /commercial-support, will be active after merge

What can be improved in another PR:

kacperwyczawski and others added 30 commits November 9, 2023 19:49
Also update daisyui to 4.0, because it introduces timeline component
@thilobillerbeck
Copy link
Collaborator

@kacperwyczawski how's progress going? Do you have a rough estimation of when you'll be finished?

@kacperwyczawski
Copy link
Contributor Author

kacperwyczawski commented Dec 12, 2023

@thilobillerbeck can you please address this, this and this? Thanks in advance. Besides these things, everything is finished.

@kacperwyczawski
Copy link
Contributor Author

Alright, with these changes I should finish on 2023-12-15 or earlier.

@kacperwyczawski
Copy link
Contributor Author

I had to make more changes to the diagram animation and the diagram itself, than I thought. I'll finish it tomorrow, sorry for delay.

@kacperwyczawski
Copy link
Contributor Author

@thilobillerbeck I'm ready for another review 🚀

Copy link
Collaborator

@thilobillerbeck thilobillerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thx for the contributions. There are some minor nitpicks I have, but to save time on communication I will fix them myself.

image
Unfortunately I'm not really happy with the NixCon section, it looks crammed together now, has thick surrounding scrollbars and does not feature the old descriptions. I will roll this back to the old design but encourage you to iterate on the idea since it is interesting, it's (apart being not in the scope for this stage of the project) not really ready imo. Please don't take this personal, we just want to get this done til the end of the year and can still incorporate this in the next stage.

Anyway, thanks for the contributions and the ideas. <3

@kacperwyczawski
Copy link
Contributor Author

kacperwyczawski commented Dec 17, 2023

No problem, I understand your decision with NixCons section. I'm glad I could help.

@thilobillerbeck thilobillerbeck merged commit d65097f into NixOS:main Dec 17, 2023
2 checks passed
garbas added a commit that referenced this pull request Jan 31, 2024
as mentioned in #1160 in this PR I rolled some changes back to reflect
the original design and fixed some smaller things

- adjusted rfc ratio
- adjusted teams layout padding
- incorporate article and tag components
- remove tailwind typography since article is more consistent
- reorder teams
- reintroduce images to the nixcon section
- fix mobile alignment for nixcon board members

---------

Co-authored-by: Rok Garbas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants