Dell XPS 13-9320 #872
Draft
Dell XPS 13-9320 #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Feb 22, 2024
|
|
||
| { | ||
| hardware.firmware = let | ||
| ivsc-firmware = with pkgs; stdenv.mkDerivation rec { |
There was a problem hiding this comment.
We might potentially want to move this to nixpkgs if it is also useful for other hardware.
There was a problem hiding this comment.
ohh, it is in nixpkgs nowadays as well I see.
There was a problem hiding this comment.
Right. In that case, we should pull it from there.
There was a problem hiding this comment.
mr created to cover add the necessary symbolic links NixOS/nixpkgs#295508
Mic92
reviewed
Feb 22, 2024
| cp firmware/ivsc_pkg_ovti01a0_0.bin $out/lib/firmware/vsc/soc_a1_prod/ivsc_pkg_ovti01a0_0_a1_prod.bin | ||
| cp firmware/ivsc_skucfg_ovti01a0_0_1.bin $out/lib/firmware/vsc/soc_a1_prod/ivsc_skucfg_ovti01a0_0_1_a1_prod.bin | ||
| cp firmware/ivsc_fw.bin $out/lib/firmware/vsc/soc_a1_prod/ivsc_fw_a1_prod.bin | ||
| ''; |
There was a problem hiding this comment.
meta.description and license would be nice to have.
bubuntux
reviewed
Mar 18, 2024
| ../../../common/cpu/intel | ||
| ../../../common/pc/laptop | ||
| ../../../common/pc/ssd | ||
| ./webcam.nix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input