Adding support for custom properties in object options - issue#172 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 15, 2022 13:39
- Adding custom properties to demo data
- changing use of the deconstruct/spread operator (...{}), in MultiSelectComponent.getSourceObj to use Object.assign(), instead.
# Conflicts: # src/app/components/select/multiple-demo.ts
SbrowneA
commented
Nov 1, 2022
| import { NG_VALUE_ACCESSOR, ControlValueAccessor } from "@angular/forms"; | ||
| import { ListItem, IDropdownSettings } from "./multiselect.model"; | ||
| import { ListFilterPipe } from "./list-filter.pipe"; | ||
| import {Component, HostListener, forwardRef, Input, Output, EventEmitter, ChangeDetectionStrategy, ChangeDetectorRef} from '@angular/core'; |
There was a problem hiding this comment.
These were automatic formatting changes made by the linter, let me know if you need them reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR aims to resolve what is described in issue#172, where other properties of an object are cleared when an item is selected.
To prevent properties from being excluded, I've simply added a new field to the list item that stores the other properties and then deconstructs the object so that the component provides the objects in their original structure.
I've tested this in single-select and multiselect mode and there have been no issues.
Keen to hear on your feedback,
Thanks.