New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed kNN for kNNBasic on issue #131 #138

Open

ODemidenko wants to merge 3 commits into NicolasHug:master from ODemidenko:kNN-top

Contributor

ODemidenko commented Jan 30, 2018

currently I introduced all the changes only to one kNN algo. If you ok with this implementation - I immediately proceed with the others

Move "Compute similarity" from AlgoBase into SymmetricAlg (as it belongs to kNN only)
implement common logic for fixed kNN
inject new logic into kNNBasic, as optional behaviour
test new behaviour vs teacher examples from Coursera course
inject new logic into kNNWithMeans, as optional behaviour
inject new logic into kNNBaseline, as optional behaviour

ODemidenko added 3 commits

January 30, 2018 16:17


fixed kNN for kNNBasic on issue NicolasHug#131


fixed kNN for kNNBasic on issue NicolasHug#131

56311f0


fixed kNN for kNNBasic on issue NicolasHug#131

39cc83a

ODemidenko force-pushed the kNN-top branch from 1ae3ad2 to 39cc83a Compare

January 30, 2018 14:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment