Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spells/Telegraphs: DamageFlag MVP & Esper Support #358

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kirmmin
Copy link
Member

@kirmmin kirmmin commented Aug 18, 2021

Features

  • Supports Telegraph DamageFlag which is a property that appears to be calculated server side. This mostly fixes the duplication of damage that we're seeing, currently. Clearly, Wildstar had multiple Telegraphs that were being checked (many either invisible or visible only in certain states). I did investigate DisplayFlags and only figured out 1 of the bits so far, but it's honestly not important at this time because we only care about tracking whether or not the telegraph should apply "damage" (or healing or buffs) to the right targets.
    • I went through about 100 Telegraphs and compared the Flags based on the caster, class, expectations of the spell (from it's text and videos) and narrowed down a few of the bits in the mask.
    • They are, obviously, up to in interpretation - they don't seem to be used in the client at all, or if they are, they are deep in the code.
  • This also adds some support for Esper Psi Points. With the Entity/Core: Vitals, Spell Costing, Dash implementation #326 PR, Vitals will allow for spell costing and this extends that to consume the rest of the Esper's Psi Points and also determine the right effects to cast based on the current Psi Points.
  • This also introduces the CastMethod Enum from the Mega Spells PR because I needed to check a CastMethod as part of the DamageFlag.

@Rawaho Rawaho added this to the Pull Request Cleanup milestone Jan 16, 2023
@Rawaho Rawaho self-assigned this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants