Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus monitoring service #95

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

salaheldinsoliman
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman commented Sep 2, 2022

Signed-off-by: salaheldinsoliman [email protected]

Closes #27

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: salaheldinsoliman <[email protected]>
@AntiD2ta AntiD2ta changed the title feat: prometheus monitoring service Add Prometheus monitoring service Sep 2, 2022
@AntiD2ta AntiD2ta added the enhancement New feature or request label Sep 2, 2022
@AntiD2ta AntiD2ta linked an issue Sep 2, 2022 that may be closed by this pull request
Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. This changes are way cleaner than in the fork. Still minor changed are required

internal/pkg/generate/generate_scripts.go Outdated Show resolved Hide resolved
internal/pkg/generate/types.go Show resolved Hide resolved
templates/services/merge/execution/geth.tmpl Outdated Show resolved Hide resolved
templates/services/merge/execution/nethermind.tmpl Outdated Show resolved Hide resolved
templates/services/merge/execution/nethermind.tmpl Outdated Show resolved Hide resolved
Signed-off-by: salaheldinsoliman <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #95 (1da387e) into develop (1d55f2b) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #95      +/-   ##
===========================================
+ Coverage    84.62%   84.87%   +0.24%     
===========================================
  Files           32       32              
  Lines         1854     1884      +30     
===========================================
+ Hits          1569     1599      +30     
  Misses         230      230              
  Partials        55       55              
Flag Coverage Δ
unittests 84.87% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/cli.go 68.90% <100.00%> (+0.39%) ⬆️
internal/pkg/generate/generate_scripts.go 96.88% <100.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@salaheldinsoliman salaheldinsoliman marked this pull request as ready for review September 6, 2022 06:12
Signed-off-by: salaheldinsoliman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Grafana and Prometheus support
3 participants