Improve connected peer distribution #7026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdacap
reviewed
May 17, 2024
| if (node.Address.Address == _localhost) | ||
| { | ||
| if (_logger.IsTrace) | ||
| _logger.Trace($"Received localhost as node address from: {msg.FarPublicKey}, node: {node}"); | ||
| continue; | ||
| } | ||
| else if (!NetworkStorage.NodesFilter.Set(node.Address.Address)) |
There was a problem hiding this comment.
I believe this should be better placed in DiscoveryManager.
asdacap
reviewed
May 17, 2024
| @@ -17,10 +20,13 @@ namespace Nethermind.Network | |||
| { | |||
| public class NetworkStorage : INetworkStorage | |||
| { | |||
| public static LruKeyCache<IPAddress> NodesFilter { get; } = new(2048, "Ip Filter"); | |||
There was a problem hiding this comment.
Please refrain from static. It breaks encapsulation.
|
Might be better to store both ports. There is no agreement about having same ports; same ports may be easier to detect by ISP/bad actors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?