Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZeroNonDec Hint Implementation #468

Merged
merged 11 commits into from
Jun 19, 2024
Merged

ZeroNonDec Hint Implementation #468

merged 11 commits into from
Jun 19, 2024
+68 −0

Conversation

Sh0g0-1758
Copy link
Contributor

Fixes: #465

@Sh0g0-1758 Sh0g0-1758 changed the title ZeroNonDec hint Implementation ZeroNonDec Hint Implementation Jun 14, 2024
TAdev0
TAdev0 requested changes Jun 17, 2024
View reviewed changes
pkg/hintrunner/zero/zerohint_signature.go Outdated Show resolved Hide resolved
pkg/hintrunner/zero/zerohint_signature_test.go Outdated Show resolved Hide resolved
TAdev0
TAdev0 requested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@TAdev0 TAdev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not go to signature, as it just check whether a field is equal to 0 or not, module secp256k1 prime

this should go to EC hints (hints related to secp256k1 so it makes sense) i think

@Sh0g0-1758
Copy link
Contributor Author

Right Relocated the hints.

@Sh0g0-1758 Sh0g0-1758 requested a review from TAdev0 June 18, 2024 18:18
har777
har777 approved these changes Jun 19, 2024
View reviewed changes
pkg/hintrunner/zero/zerohint_ec_test.go Outdated Show resolved Hide resolved
TAdev0
TAdev0 requested changes Jun 19, 2024
View reviewed changes
pkg/hintrunner/zero/zerohint.go Outdated Show resolved Hide resolved
@Sh0g0-1758
Copy link
Contributor Author

Hmm... There are some serious branch issues going on here. It seems like two branches have merged for some reason. Wait Let me correct it.

@Sh0g0-1758
Copy link
Contributor Author

@TAdev0 , we good to merge now ?

@TAdev0 TAdev0 merged commit f2ed58c into NethermindEth:main Jun 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@har777 har777 har777 approved these changes

@TAdev0 TAdev0 TAdev0 approved these changes

@cicr99 cicr99 Awaiting requested review from cicr99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IsZeroNondet
3 participants
@Sh0g0-1758 @har777 @TAdev0