Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poseidon hash builtin #437

Merged
merged 14 commits into from
Jun 17, 2024
Merged

Poseidon hash builtin #437

merged 14 commits into from
Jun 17, 2024

Conversation

MaksymMalicki
Copy link
Contributor

No description provided.

@MaksymMalicki MaksymMalicki self-assigned this Jun 3, 2024
@MaksymMalicki MaksymMalicki marked this pull request as draft June 3, 2024 15:40
@MaksymMalicki MaksymMalicki linked an issue Jun 3, 2024 that may be closed by this pull request
@MaksymMalicki
Copy link
Contributor Author

@cicr99 I used this implementation of hades permutation and poseidon hash (https://github.com/NethermindEth/juno/blob/main/core/crypto/poseidon_hash.go), which returns only the first element of the three elements state. I had to make some modifications inside and can't use it as a package rn. Is it ok to leave this copy-pasted code, or should I come up with sth else

@MaksymMalicki MaksymMalicki marked this pull request as ready for review June 5, 2024 13:15
@TAdev0
Copy link
Contributor

TAdev0 commented Jun 11, 2024

@MaksymMalicki can i start reviewing it as the final version?

@MaksymMalicki
Copy link
Contributor Author

@TAdev0 yeah sure, just don't review the poseidon hash math itself, as I'm going to remove it entirely, once the new release of Juno with updated crypto package is out

@TAdev0
Copy link
Contributor

TAdev0 commented Jun 11, 2024

ok got it will review today

Copy link
Contributor

@TAdev0 TAdev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems alll good for me! I approve and lets wait for Juno to release the new function so that you can import PoseidonPerm directly

pkg/vm/builtins/poseidon.go Show resolved Hide resolved
pkg/vm/builtins/poseidon.go Outdated Show resolved Hide resolved
pkg/vm/builtins/poseidon.go Show resolved Hide resolved
pkg/vm/builtins/poseidon.go Outdated Show resolved Hide resolved
pkg/vm/builtins/poseidon_test.go Outdated Show resolved Hide resolved
@MaksymMalicki MaksymMalicki merged commit bad9ca8 into main Jun 17, 2024
4 checks passed
@MaksymMalicki MaksymMalicki deleted the poseidon-hash-builtin branch June 17, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poseidon Hash
3 participants