Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getIgnore method to HttpQueryParams getting UpperCase queryParams #1672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add getIgnore method to HttpQueryParams getting UpperCase queryParams #1672

wants to merge 1 commit into from

Conversation

mrlee7
Copy link

@mrlee7 mrlee7 commented Oct 22, 2023

Related issue: #527

Motivation

  • In the HttpQueryParams class, when invoking get("cityId"), the key is converted to lowercase, causing the value associated with the key cityId returns as null.
    • To address this issue, I've added a function that recognizes uppercase characters within the key.

Modification

  • Add getIgnoreCase(String name) on HttpQueryParams

Result

@mrlee7 mrlee7 force-pushed the fix-get-ignore-query-params branch from 9ba6f05 to 9e8b9e5 Compare November 2, 2023 10:44
@mrlee7 mrlee7 mentioned this pull request Nov 2, 2023
Open
@mrlee7 mrlee7 marked this pull request as draft May 7, 2024 11:09
@mrlee7 mrlee7 marked this pull request as ready for review May 7, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zuul2 HttpQueryParams get() method issue
1 participant
@mrlee7