Replace awscli v1 with boto3 during environment bootstrapping #1778
Conversation
trhodeos
changed the title
|
@madhur-ob sorry I had to fix some formatting / precommit issues. When you get the chance, would you mind re-reviewing? |
|
Thanks @madhur-ob .. It looks like some tests failed.. Perhaps they are flaky? Also, would it be possible to run the |
| @@ -4,6 +4,22 @@ | |||
| from metaflow.exception import MetaflowException | |||
|
|
|||
|
|
|||
| def parse_s3_full_path(s3_uri): | |||
There was a problem hiding this comment.
@trhodeos is there any specific reason to create a utility function? maybe we can have this snippet live right next to L:91 in metaflow_environment.py. it will help in making the code much more readable (avoiding an extra jump to a different file)
There was a problem hiding this comment.
This mirrors what we do for azure and gcs. I was just following convention here, happy to pull this inline if you think it's better.
|
|
||
| # <scheme>://<netloc>/<path>;<params>?<query>#<fragment> | ||
| scheme, netloc, path, _, _, _ = urlparse(s3_uri) | ||
| assert scheme == "s3" |
There was a problem hiding this comment.
within metaflow code base, we have elected to not use assert statements. also, when the assert statement fails, the user is left no better in their understanding of how to fix the issue
There was a problem hiding this comment.
This is copied from parse_gcs_full_path.. Happy to remove it though if we don't want it!
| bucket = netloc | ||
| path = path.lstrip("/").rstrip("/") | ||
| if path == "": | ||
| path = None |
There was a problem hiding this comment.
we don't expect this to be None
There was a problem hiding this comment.
Yep, removing it makes sense for this use case.. I sound like a broken record at this point, but I just copied this wholesale from parse_gcs_full_path.
| assert netloc is not None | ||
|
|
||
| bucket = netloc | ||
| path = path.lstrip("/").rstrip("/") |
There was a problem hiding this comment.
I don't think we need it for this case, but just keeping this in line with the other parse functions.. We can probably remove if we just inline this.
Fixes #387