[Keep open as reminder] fix missing tag problem in resume #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinyu
changed the title
darinyu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will use client to copy previous tags from original run to new run.
We do not want to use data store because tags may be mutable by client whileas data store is more of a append only store.
Edit April 8: We are hesitant about merging this PR directly because it is not 100% certain whether users want all the user tags re-populate in a resume. Currently, the behavior will remain the same, and user tags will not inherit from old runs. Should we see more cases or complaints about the missing tags, we can re-discuss the issue and add this change in.