Add support for Kueue. #1754
Open
Add support for Kueue. #1754
+86
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mergeable anytime from my end -- no impact on core. |
shrinandj
force-pushed
the
shri/add-kueue-support
branch
from
e529c40
to
3716880
Compare
This commit adds support for using Kueue to submit jobs/pods into Kubernetes. There are two config options: - KUEUE_ENABLED: set to True/False - KUEUE_LOCALQUEUE_NAME: set to the name of the localqueue configured with Kueue. See [this](https://kueue.sigs.k8s.io/docs/concepts/local_queue) for details The config options can be set in the main metaflow config or via the @kubernetes decorator. Testing Done: - Verified that specifying kueue config options in Metaflow config (~/.metaflowconfig/json) works as expected. - Verified that specifying kueue config options in @kubernetes works as expected - Verified that @kubernetes options take precedence over the global config - If the global KUEUE_ENABLED config is True, but locally set to False for a particular step, the step does not run with Kueue. - Verified that the kueue labels and annotations are set correctly and kueue actually runs the jobs. - Verified that if kueue is configured to manage "pod", Metaflow create argo-workflow pods are scheduled by kueue. - Verified that the default behavior is to not use Kueue and everything works correctly as before (jobs and argo-workflows)
shrinandj
force-pushed
the
shri/add-kueue-support
branch
from
3716880
to
fe780f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for using Kueue to submit jobs/pods into Kubernetes. There are two config options:
The config options can be set in the main metaflow config or via the @kubernetes decorator.
Testing Done:
Verified that specifying kueue config options in Metaflow config (~/.metaflowconfig/json) works as expected.
Verified that specifying kueue config options in @kubernetes works as expected
Verified that @kubernetes options take precedence over the global config
Verified that the kueue labels and annotations are set correctly and kueue actually runs the jobs.
Verified that if kueue is configured to manage "pod", Metaflow create argo-workflow pods are scheduled by kueue.
Verified that the default behavior is to not use Kueue and everything works correctly as before (jobs and argo-workflows)