Get OOM errors to stderr and the UI #1696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race between Metaflow detecting that a pod failed execution and the reason for pod failure being set on the pod. As a result, at times, the failure reason doesn't posted to stderr. This change makes Metaflow try a little harder to get the reason for the failures. For pods that get OOM killed, this change worked just fine. Without this change, the OOM killed pod would simply die and the user would have no idea why. With this change, the error on stderr shows: Task ran out of memory. Increase the available memory by specifying @resource(memory=...) for the step.
shrinandj
force-pushed
the
shri/get-oom-error-stderr
branch
from
5fa834f
to
8c750f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race between Metaflow detecting that a pod failed execution and the reason for pod failure being set on the pod. As a result, at times, the failure reason doesn't posted to stderr.
This change makes Metaflow try a little harder to get the reason for the failures.
For pods that get OOM killed, this change worked just fine.
Without this change, the OOM killed pod would simply die and the user would have no idea why. With this change, the error on stderr shows: