Add capability to add custom tags to batch #1628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limess
force-pushed
the
1627-custom-batch-tags
branch
3 times, most recently
from
f72a022
to
d1199b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1627.
Adds:
BATCH_DEFAULT_TAGSto metaflow config - a map of default AWS tags to apply to batch jobstagskwarg to the AWS batch decorator - a map of AWS tags to apply to batch jobs (applied last)--aws-tagsto the CLI (to avoid clashing with metaflow tags.All of these only apply when
BATCH_EMIT_TAGSis set to avoid IAM problems.I haven't done any manual testing here as I'm not sure the best way to go around that?