enable consumers to implement MasterMain and rename LeadershipManager to remove ZK #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcowgill-stripe
requested review from
calvin681,
sundargates,
Andyz26,
hmitnflx and
fdc-ntflx
as code owners
sundargates
approved these changes
May 15, 2024
Test Results134 files ±0 134 suites ±0 7m 46s ⏱️ +18s For more details on these failures, see this check. Results for commit dbd6e88. ± Comparison against base commit 56e0a1c. ♻️ This comment has been updated with latest results. |
mcowgill-stripe
force-pushed
the
mcowgill-changes-for-master-main
branch
from
d98e66a
to
f10f1c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order for teams to re-implement the MasterMain functionality of the Mantis Server the ServiceLifecycle functions need to be available to teams. I've changed those to be public, but I'm happy to find another solution or extract an interface here.
UPDATE: I am reverting this part of the change.
Second the LeadershipManagerZKImpl to the best of my knowledge is a ZK independent leadership manager. We are implementing a leader elector based on DynamoDB and are able to use this LeadershipManager without modifying it. This name change is proposing to reflect the fact other teams can reuse the Leadership Manager when implementing their own leader election.
In order to change this name it appears I'll need to deprecate as some tests are failing. I'll consider this in a future PR to expand leader election options in Mantis.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests