Use injected usage supplier in RuntimeTaskImpl. #648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavdugar
requested review from
calvin681,
sundargates,
Andyz26,
hmitnflx and
fdc-ntflx
as code owners
arnavdugar
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
requested changes
Apr 3, 2024
| @@ -99,8 +99,9 @@ public void initialize( | |||
| this.wrappedExecuteStageRequest = | |||
| new WrappedExecuteStageRequest(PublishSubject.create(), executeStageRequest); | |||
|
|
|||
| log.info("Picking Cgroups metrics collector."); | |||
| configWritable.setMetricsCollector(CgroupsMetricsCollector.valueOf(System.getProperties())); | |||
| MetricsCollector metricsCollector = config.getUsageSupplier(); | |||
There was a problem hiding this comment.
hi @arnavdugar we are trying to move away from passing objects via the config class and this config class you use here is generated from the serialized version (L94 -96) so the supplier is always empty.
If you need to support another metrics collector I would suggest adding a config value as string and then construct the metrics collector type instance based the string value instead (basically treat the current interface at initialize as entry and do not pass external instances from there). We need this assumption to support our internal wrapper to these entries.
|
I accidentally closed this PR, so I created #674. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use injected usage supplier in
RuntimeTaskImpl.Context
Currently
CgroupsMetricsCollectoris hard-coded inRuntimeTaskImpl.java, so if it is overridden using themantis.taskexecutor.metrics.collectorfield in the Mantis agent properties, that isn't respected. This change uses the dynamically loaded implementation ofMetricsCollector.Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests