Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change metrics with micrometer in mantis-server #533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

change metrics with micrometer in mantis-server #533

wants to merge 2 commits into from

Conversation

7ue5wu
Copy link

@7ue5wu 7ue5wu commented Aug 22, 2023

Context

Explain context and other details for this pull request.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@7ue5wu 7ue5wu had a problem deploying to Integrate Pull Request August 22, 2023 04:10 — with GitHub Actions Failure
hmitnflx
hmitnflx reviewed Aug 22, 2023
View reviewed changes
...server-worker-client/src/main/java/io/mantisrx/server/worker/client/SseWorkerConnection.java Outdated Show resolved Hide resolved
...server-worker-client/src/main/java/io/mantisrx/server/worker/client/SseWorkerConnection.java Outdated Show resolved Hide resolved
...server-worker-client/src/main/java/io/mantisrx/server/worker/client/SseWorkerConnection.java Outdated Show resolved Hide resolved
...server-worker-client/src/main/java/io/mantisrx/server/worker/client/SseWorkerConnection.java Outdated Show resolved Hide resolved
...server-worker-client/src/main/java/io/mantisrx/server/worker/client/SseWorkerConnection.java Outdated Show resolved Hide resolved
...server-worker-client/src/main/java/io/mantisrx/server/worker/client/SseWorkerConnection.java Outdated Show resolved Hide resolved
...orker-client/src/main/java/io/mantisrx/server/worker/client/SseWorkerConnectionFunction.java
@@ -58,25 +57,23 @@ public void call(Throwable throwable) {
// Use single netty thread
NettyUtils.setNettyThreads();

metricGroupId = new MetricGroupId(DROP_OPERATOR_INCOMING_METRIC_GROUP + "_SseWorkerMetricsConnectionFunction_withBuffer");
metricsSet.add(metricGroupId);
metricGroup = (DROP_OPERATOR_INCOMING_METRIC_GROUP + "_SseWorkerMetricsConnectionFunction_withBuffer");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a comment here to take a look at it later.

...r/mantis-server-worker/src/main/java/io/mantisrx/server/worker/DataDroppedPayloadSetter.java Outdated Show resolved Hide resolved
...s-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/TaskExecutorStarter.java Outdated
@@ -129,6 +132,11 @@ public TaskExecutorStarterBuilder rpcSystem(RpcSystem rpcSystem) {
return this;
}

public TaskExecutorStarterBuilder registry(MeterRegistry meterRegistry) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method called anywhere? I don't think we'll pass MeterRegistry in TaskExecutorStarter.
Note to self: Investigate this more!

@7ue5wu 7ue5wu had a problem deploying to Integrate Pull Request September 5, 2023 20:45 — with GitHub Actions Failure
@7ue5wu 7ue5wu had a problem deploying to Integrate Pull Request September 5, 2023 20:49 — with GitHub Actions Failure
hmitnflx
hmitnflx reviewed Sep 5, 2023
View reviewed changes
...orker-client/src/main/java/io/mantisrx/server/worker/client/SseWorkerConnectionFunction.java Outdated
", onComplete=" + onComplete.value() + ", dropped=" + dropped.value()
for (String metricGroup : metricGroups) {
if (metricGroup != null) {
final Counter onNext = meterRegistry.counter(metricGroup + "_DropOperator_" + ("" + DropOperator.Counters.onNext));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will also be using Search.in(meterRegistry).name(n -> n.startsWith(metricGroup) && n.endsWith(DropOperator.Counters.onNext.toString())).counter()

@7ue5wu 7ue5wu had a problem deploying to Integrate Pull Request September 10, 2023 20:19 — with GitHub Actions Failure
@7ue5wu 7ue5wu had a problem deploying to Integrate Pull Request September 10, 2023 20:29 — with GitHub Actions Failure
@7ue5wu 7ue5wu had a problem deploying to Integrate Pull Request September 10, 2023 21:20 — with GitHub Actions Failure
@7ue5wu 7ue5wu had a problem deploying to Integrate Pull Request September 26, 2023 20:12 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmitnflx hmitnflx hmitnflx left review comments

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@jeffchao jeffchao Awaiting requested review from jeffchao

@piygoyal piygoyal Awaiting requested review from piygoyal

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@sundargates sundargates Awaiting requested review from sundargates sundargates is a code owner

@Andyz26 Andyz26 Awaiting requested review from Andyz26 Andyz26 is a code owner

@markcho markcho Awaiting requested review from markcho

@liuml07 liuml07 Awaiting requested review from liuml07

@fdc-ntflx fdc-ntflx Awaiting requested review from fdc-ntflx fdc-ntflx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@7ue5wu @hmitnflx