Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed Carousel Variant: Dark - Video and Autoscroll #208

Open
2 tasks
Gonzalo-CG opened this issue Jan 25, 2024 · 2 comments
Open
2 tasks

Tabbed Carousel Variant: Dark - Video and Autoscroll #208

Gonzalo-CG opened this issue Jan 25, 2024 · 2 comments

Comments

@Gonzalo-CG
Copy link
Collaborator

Description

This issue must be picked after #144

This issue aims to add the tab auto-scrolling functionality and the ability to add videos to tabs to the Tabbed Carousel Variant: Dark Block.

Acceptance Criteria

  • As an author, I can add a video to any tab (instead of an image)
  • The tabs of the component auto-scroll.

Open Questions

  1. Does it make sense to have auto-scroll? We would need 2 pause buttons, one for the video and another one for the auto-scrolling.
  2. If we do have auto-scroll, what should the time interval be?
@Gonzalo-CG Gonzalo-CG added this to the MT Bulldog Magazine milestone Jan 25, 2024
@shirin27 shirin27 self-assigned this Jan 30, 2024
@shirin27 shirin27 added the SRB tickets that need to be discussed in the SRB label Jan 30, 2024
@shirin27 shirin27 assigned WendyKruger and unassigned shirin27 Jan 30, 2024
@shirin27
Copy link
Collaborator

shirin27 commented Feb 6, 2024

Design was updated to include the pause button in the upper right corner, and a toggle for the auto-scroll in the lower left corner.

@shirin27 shirin27 removed the SRB tickets that need to be discussed in the SRB label Feb 13, 2024
@shirin27
Copy link
Collaborator

Kamino cloned this issue to hlxsites/vg-macktrucks-com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants