-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabbed Carousel Variant: Dark #144
Comments
I believe I addressed this in one of the calls, but just in case here are the answers to the design questions: Open Questions
|
Color contrast of inactive items is not sufficient for the small text. The contrast ratio of 3.9 can only be used for 18px+ text. It’s #000 at 50% opacity, which results in #808080. With 55% opacity we’ll end up with #747474 and an acceptable contrast ratio of 4.6. |
Kamino cloned this issue to hlxsites/vg-macktrucks-com |
Description
A new block, similar to the Tabbed Carousel Block will be developed in order to achieve the design named in Figma as Group 700.
The design is the following:
Acceptance Criteria
Open Questions
Is this a tabbed carousel, or 2 separate components (a hero and some buttons below)?--> This is just one "tabbed-carousel" component.Is the "Driven by Design" text a link?--> YesDoes every tab of the carousel have the "subscribe" button overlayed on the top-right corner?--> YesDoes this block auto-scroll?--> YesThe text was updated successfully, but these errors were encountered: