Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed Carousel Variant: Dark #144

Open
7 tasks
Gonzalo-CG opened this issue Oct 24, 2023 · 3 comments
Open
7 tasks

Tabbed Carousel Variant: Dark #144

Gonzalo-CG opened this issue Oct 24, 2023 · 3 comments

Comments

@Gonzalo-CG
Copy link
Collaborator

Gonzalo-CG commented Oct 24, 2023

Description

A new block, similar to the Tabbed Carousel Block will be developed in order to achieve the design named in Figma as Group 700.

The option to add a video to tabs and the auto-scrolling of tabs will be handled separately on issue #208

The design is the following:
Screenshot of design

Acceptance Criteria

  • The Dark variant of the Tabbed Carousel Block is available for authors to use on any page.
  • The Dark variant of the Tabbed Carousel Block has the same design for Desktop & mobile as shown in Figma.
  • As an author, I can configure the link that's displayed on every tab. (The Driven By Design text overlapping the media is a link). This text is manually added by the author
  • The block is one tabbed carousel component - Not split into two blocks
  • Each item links to a magazine article
  • The category and title of an article are pulled from the metadata
  • If the title of an article is too long, it gets truncated with an ellipsis (to be defined when this happens)

Open Questions

  • Is this a tabbed carousel, or 2 separate components (a hero and some buttons below)? --> This is just one "tabbed-carousel" component.
  • Is the "Driven by Design" text a link? --> Yes
  • Does every tab of the carousel have the "subscribe" button overlayed on the top-right corner? --> Yes
  • Does this block auto-scroll? --> Yes
@Gonzalo-CG Gonzalo-CG added Question Further information is requested Bulldog magazine Design Question RE/Dev team has open questions regarding the designs. and removed Question Further information is requested labels Oct 24, 2023
@WendyKruger
Copy link
Collaborator

I believe I addressed this in one of the calls, but just in case here are the answers to the design questions:

Open Questions

  • Is this a tabbed carousel, or 2 separate components (a hero and some buttons below)? tabbed carousel
  • Is the "Driven by Design" text a link? Yes
  • Does every tab of the carousel have the "subscribe" button overlayed on the top-right corner? Yes
  • Does this block auto-scroll? Yes

@WendyKruger WendyKruger removed the Design Question RE/Dev team has open questions regarding the designs. label Nov 20, 2023
@BeckyMedlin BeckyMedlin removed their assignment Nov 20, 2023
@cogniSyb
Copy link
Collaborator

Color contrast of inactive items is not sufficient for the small text. The contrast ratio of 3.9 can only be used for 18px+ text. It’s #000 at 50% opacity, which results in #808080. With 55% opacity we’ll end up with #747474 and an acceptable contrast ratio of 4.6.

@shirin27
Copy link
Collaborator

Kamino cloned this issue to hlxsites/vg-macktrucks-com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants