add webpack tests #106
Merged
add webpack tests #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
easingthemes
commented
Dec 19, 2023
easingthemes
commented
- Add Webpack tests
- fix missing/deprecated babel lugin
…d into feature/webpack-tests
easingthemes
commented
Dec 19, 2023
| // extend log to proper say what file is running | ||
| module.exports = (config) => { | ||
| // checking all entries at this configuration | ||
| const entry = generateEntries(config); | ||
| return new Promise((r) => { |
There was a problem hiding this comment.
The only change here is wrapping the task to Promise.
| if (config && config.general && config.general.watch) { | ||
| try { | ||
| log(__filename, 'Watcher Sass / autoprefixer running...', '', 'info'); | ||
| return new Promise((resolve) => { |
There was a problem hiding this comment.
The only change here is wrapping the task to Promise.
| ) | ||
| ); | ||
| module.exports = async function renderStyles(file, dest, config) { | ||
| return new Promise((resolve) => { |
There was a problem hiding this comment.
The only change here is wrapping the task to Promise.
| @@ -41,7 +41,7 @@ | |||
| "@babel/plugin-transform-runtime": "^7.23.2", | |||
| "@babel/preset-env": "^7.23.2", | |||
| "autoprefixer": "^10.4.16", | |||
| "babel-loader": "^9.1.3", | |||
| "babel-loader": "9.1.2", | |||
There was a problem hiding this comment.
Latest version has a bug: babel/babel-loader#1015
| @@ -7,7 +7,7 @@ module.exports = { | |||
| loader: 'babel-loader', | |||
| options: { | |||
| presets: [['@babel/preset-env', { useBuiltIns: 'usage', corejs: 3 }]], | |||
| plugins: ['@babel/plugin-transform-runtime', '@babel/plugin-proposal-object-rest-spread'] | |||
There was a problem hiding this comment.
plugin is deprecated
FelipeSimoes
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.