Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 解决页面切换的问题 #15434

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guoenxuan
Copy link
Contributor

@guoenxuan guoenxuan commented Apr 2, 2024

  • 解决pageNo===0时,即打开第1个页面时在鸿蒙平台动画不能真正的停止的问题
  • 解决返回时上一个页面瞬间白屏的问题

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 58.48%. Comparing base (4c79d5c) to head (3cc715f).
Report is 24 commits behind head on main.

❗ Current head 3cc715f differs from pull request most recent head d7ccb5a. Consider uploading reports for the commit d7ccb5a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15434      +/-   ##
==========================================
- Coverage   58.53%   58.48%   -0.05%     
==========================================
  Files         491      491              
  Lines       21882    21902      +20     
  Branches     5621     5628       +7     
==========================================
+ Hits        12808    12810       +2     
+ Misses       7909     7908       -1     
- Partials     1165     1184      +19     
Flag Coverage Δ
taro-cli 63.29% <ø> (+5.88%) ⬆️
taro-runner 46.25% <ø> (ø)
taro-runtime 65.35% <ø> (ø)
taro-web 40.22% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/taro-router/src/style.ts 25.00% <ø> (ø)
packages/taro-router/src/router/spa.ts 10.19% <0.00%> (-0.27%) ⬇️
packages/taro-router/src/router/page.ts 5.28% <0.00%> (-0.16%) ⬇️

... and 16 files with indirect coverage changes

@guoenxuan guoenxuan force-pushed the fix-page-turn branch 2 times, most recently from 17a2b27 to 3617d2b Compare April 3, 2024 06:05
This was referenced Apr 6, 2024
@guoenxuan guoenxuan force-pushed the fix-page-turn branch 2 times, most recently from 3cc715f to 18fb7c6 Compare April 8, 2024 06:15
guoenxuan and others added 2 commits April 8, 2024 14:15
* 解决pageNo===0时,即打开第1个页面时在鸿蒙平台动画不能真正的停止的问题
* 解决返回时上一个页面瞬间白屏的问题
@ZEJIA-LIU
Copy link
Contributor

这个 pr 看起来是做了两件事情,最好分开提合并起来会方便一些。
要简明写一些 这个 pr 做了什么事情,是什么类型的 pr,改动涉及到哪一些平台。
由于改动的的属于公共包,所以如果是修复问题的话,最好关联相关 issue,或者提供可复现的 demo 以及复现路径

@ZakaryCode ZakaryCode added A-router Area - H5 路由相关 T-h5 Target - 编译到 H5 labels May 2, 2024
This was referenced May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-router Area - H5 路由相关 T-h5 Target - 编译到 H5
Projects
Status: Padding
Development

Successfully merging this pull request may close these issues.

None yet

3 participants