Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contributes three things:
EnableLinkDetachWithDragClick
.@Auburn, if you are still around, wondering if you could give this branch a spin. You鈥檝e been very good at spotting broken interaction code, and this branch rewrites everything 馃槗 I will leave this pr open for a while while I continue my own tests.
More details about each change below.
Move links from the object pool to a vector
This change boils down to
When
BeginNodeEditor
is called, the vector is resized to zero. Links are appended to the vector inImNodes::Link()
. InEndNodeEditor
, we render them. Links are now truly immediate-mode and really simple.Subtle bugs occurring on id reuse, such as this #91 no longer apply to links. The goal is to apply this change for nodes and pins as well.
Rebuild link, node, pin interaction
Remove the EnableLinkDetachWithDragClick attribute flag
Test checklist