Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace loaderUtils.parseQuery with loaderUtils.getOptions #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace loaderUtils.parseQuery with loaderUtils.getOptions #409

wants to merge 1 commit into from

Conversation

1pete
Copy link
Contributor

@1pete 1pete commented Sep 1, 2018

loaderUtils.parseQuery is deprecated, see webpack/loader-utils#56

@GGAlanSmithee
Copy link
Collaborator

GGAlanSmithee commented Sep 5, 2018

Hi @1pete thanks for your contribution. travis is passing, and it looks like AppVeyor complains about a certificate, unrelated to this PR.

@NekR Seems like the deprecation notice was added over a year ago according to the linked thread, is there a reason why we have not updated to use getOptions instead? Should probably be safe to merge this, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants