Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for 'projectName' setting (#2107) #5801

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

apburgess
Copy link

PR Checklist

What is the current behavior?

Currently the files generated during the build process take the project name from the basename of the directory the project is contained in.

What is the new behavior?

If (and only if) the new 'projectName' setting is present in the nativescript.config.ts file, the name specified there is used instead of the basename of the project directory.

Fixes/Implements/Closes #2107
(Note on iOS this requires an additional patch to @nativescript/webpack5 that will be linked below)

Copy link

cla-bot bot commented Apr 22, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Adrian Burgess.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@apburgess
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Apr 23, 2024
Copy link

cla-bot bot commented Apr 23, 2024

The cla-bot has been summoned, and re-checked this pull request!

@apburgess
Copy link
Author

apburgess commented Apr 26, 2024

Linked to PRs NativeScript/NativeScript#10550 and NativeScript/docs#143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: More control over what the .xcodeproj is named
2 participants