Networking category to @nativescript/core and added the docs for the Color, Connectivity, and HTTP modules as its subcategories. #87

Ombuweb · 2022-06-19T10:14:35Z

Other subcategories docs are in progress

…/core subcategories' files there.

cla-bot · 2022-06-19T10:14:39Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Nandee89, @Ombuweb.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

….md and connectivity.md and instead made them complete,no need to point other pages

cla-bot · 2022-06-19T21:41:22Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Nandee89, @Ombuweb.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot · 2022-06-20T23:30:31Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Nandee89, @Ombuweb.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

cla-bot · 2022-06-21T15:04:37Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-06-22T22:44:54Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-06-23T19:09:15Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

rigor789

Just had a quick look (haven't had the chance to give this a proper read through), but this all looks great, awesome job so far!

I left a few notes where I think there's room for improvement, mainly around tabs and grouping code blocks.

I don't think we have a good reference for these features of the docs, so I'll post them here:

Types of tabs:

Flavor tabs
Code tabs

1. Flavor tabs

These are tabs meant to switch between different flavors (angular, vue, plain etc.) and can contain anything (notes, paragraphs, code blocks etc). They are defined as follows:

/// flavor <name>

 <!-- any content here -->

///

When there are multiple flavor containers next to each other (subsequently) they are automatically grouped together.

When a user switches flavors, the choice is persisted in localStorage and updated for every flavor switcher on the page, and remembered when the user reloads the page.

2. Code tabs

These are meant to group related code blocks together, or show off a snippet in JS/TS versions.

A good example for related code blocks is when there are multiple files required for a feature... for example angular components:

'''html
<!-- the component html -->
'''
'''typescript
// the ts code for the component
'''

These would produce a html and a typescript tab.

If you need to change the tab name, you can add a comment above a code block like this:

<!-- tab: MyCustomTab Title -->
'''html
<!-- the component html -->
'''
<!-- tab: An even cooler tab -->
'''typescript
// the ts code for the component
'''

(note: in VSCode you can add these quickly with Ctrl+/ or Cmd+/ on mac and then just type tab: <name>)

If you have subsequent code blocks that you do not want to get grouped, you can separate them with an empty comment:

'''html
  // ...
'''
<!-- -->
'''typescript
  // ...
'''

Note I have used ' instead of a backtick in the above examples, but they should actual backticks in the docs.

rigor789 · 2022-06-23T19:12:14Z

nativescript-core/Application.md

+/// flavor javascript
+
+```javascript
+import { Application } from '@nativescript/core'
+```
+
+///
+
+/// flavor typescript
+
+```typescript
+import { Application } from '@nativescript/core'
+```
+
+///


Suggested change

/// flavor javascript

```javascript

import { Application } from '@nativescript/core'

```

///

/// flavor typescript

```typescript

import { Application } from '@nativescript/core'

```

///

```typescript

import { Application } from '@nativescript/core'

We don't really need to have a flavor switcher in this case, as both of these are identical.

rigor789 · 2022-06-23T19:13:57Z

nativescript-core/Application.md

+/// flavor javascript
+
+```javascript
+const androidApp = Application.android
+```
+
+///
+
+/// flavor typescript
+
+```typescript
+const androidApp: AndroidApplication = Application.android
+```
+
+///


Removing the /// flavor X wrappers here would work, as any subsequent code-blocks will be grouped into tabs, for example (using ' instead of backticks for the example as otherwise it wouldn't render in my comment)

'''javascript // ... ''' '''typescript // ... '''

will produce a javascript/typescript tab group.

rigor789 · 2022-06-23T19:17:26Z

nativescript-core/Application.md

+/// flavor javascript
+
+```javascript
+const nativeApp = androidApp.nativeApp
+```
+
+///
+/// flavor typescript
+
+```typescript
+const nativeApp: android.app.Application = androidApp.nativeApp
+```
+
+///


Same as previous comment about grouping subsequent code blocks into tabs (a few more places like this, will not comment on each :) )

Hi @rigor789. Thank you very much for your feedback. You just taught me new stuff :). I will make the suggested changes.

cla-bot · 2022-06-24T22:55:08Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-07-08T15:56:13Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-07-08T16:42:22Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-08-13T17:36:46Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-08-14T19:54:12Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-09-19T23:05:39Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-10-04T22:05:32Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Ombuweb

Since there's a plan to drop @nativescript/theme and mainly support @nativescript/tailwind, I think it's better to mention @nativescript/tailwind here. Not sure if it provides all CSS to {N} though, or just a subset.

cla-bot · 2022-10-05T14:47:41Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-10-05T21:17:08Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-10-17T22:11:33Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-10-18T10:23:14Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-10-18T17:28:31Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-10-18T17:33:24Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-10-19T14:52:51Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2022-10-26T09:39:56Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nandesora Tjihero.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email [email protected]
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Nandesora Tjihero and others added 6 commits June 13, 2022 18:37

Added API description for the Payments: IAP & Subscriptions plugin

87a6f6a

Added @nativescript/core subcategories names and their links.

f9452d0

I created the nativescript-core directory and moved the @nativescript…

ce4e1ed

…/core subcategories' files there.

Moved it to nativescript-core folder and added Connection Types info

2c22083

Added the documentation for the subcategory

7c39be2

It was moved to nativescript-core folder

c7e2507

Removed broken/inconsistent links (API reference sections ) from http…

469929d

….md and connectivity.md and instead made them complete,no need to point other pages

Ombuweb force-pushed the develop branch from 73ce845 to 469929d Compare June 19, 2022 21:41

Added Application.android properties info

1505164

Ombuweb added 3 commits June 21, 2022 17:02

Added back API References section with full links

255d4a7

Added back the API References section

2f7ead2

Completed the docs of Android API part of the Application module

c4250dc

Added more content

3aa4793

Completed the Application module category

a799594

rigor789 reviewed Jun 23, 2022

View reviewed changes

Remove the unnecessary flavor tabs

b7f931d

Merge remote-tracking branch 'origin/develop' into pr/87

c3ffeb6

chore: adjusting header order and naming

15d397f

Ombuweb added 3 commits July 9, 2022 19:46

Added ApplicationSettings link

9310ce5

Edited content

7ee4567

Editted content

b809634

Updated

e7ea4be

rigor789 added the documentation Improvements or additions to documentation label Aug 21, 2022

Ombuweb mentioned this pull request Sep 10, 2022

fix: broken links #100

Open

Ombuweb added 5 commits September 20, 2022 01:00

fix: added Preview

fd5f48d

fix: added Preview

72ae9df

fix: added Preview

9b96c59

chore: clean up

f216f82

feat: added Preview

59309c1

fix: python install correction

5a8a4e0

fix: referencing tailwind

a5101c9

Ombuweb commented Oct 5, 2022

View reviewed changes

fix: added new methods

4162fa0

fix: development workflow restructured and debugging WIP

788878b

chore: WIP only images left before it's completed

2316296

chore: done

f18a02c

chore: Corrected the nesting of the ON THIS PAGE links

d51c62e

fix: added image

a33eabb

feat: added the Fps Meter module

486da62

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Networking category to @nativescript/core and added the docs for the Color, Connectivity, and HTTP modules as its subcategories. #87

Networking category to @nativescript/core and added the docs for the Color, Connectivity, and HTTP modules as its subcategories. #87

Ombuweb commented Jun 19, 2022

cla-bot bot commented Jun 19, 2022

cla-bot bot commented Jun 19, 2022

cla-bot bot commented Jun 20, 2022

cla-bot bot commented Jun 21, 2022

cla-bot bot commented Jun 22, 2022

cla-bot bot commented Jun 23, 2022

rigor789 left a comment

rigor789 Jun 23, 2022

rigor789 Jun 23, 2022

rigor789 Jun 23, 2022

Ombuweb Jun 24, 2022

cla-bot bot commented Jun 24, 2022

cla-bot bot commented Jul 8, 2022

cla-bot bot commented Jul 8, 2022

cla-bot bot commented Aug 13, 2022

cla-bot bot commented Aug 14, 2022

cla-bot bot commented Sep 19, 2022

cla-bot bot commented Oct 4, 2022

Ombuweb left a comment

cla-bot bot commented Oct 5, 2022

cla-bot bot commented Oct 5, 2022

cla-bot bot commented Oct 17, 2022

cla-bot bot commented Oct 18, 2022

cla-bot bot commented Oct 18, 2022

cla-bot bot commented Oct 18, 2022

cla-bot bot commented Oct 19, 2022

cla-bot bot commented Oct 26, 2022

Networking category to @nativescript/core and added the docs for the Color, Connectivity, and HTTP modules as its subcategories. #87

Are you sure you want to change the base?

Networking category to @nativescript/core and added the docs for the Color, Connectivity, and HTTP modules as its subcategories. #87

Conversation

Ombuweb commented Jun 19, 2022

cla-bot bot commented Jun 19, 2022

cla-bot bot commented Jun 19, 2022

cla-bot bot commented Jun 20, 2022

cla-bot bot commented Jun 21, 2022

cla-bot bot commented Jun 22, 2022

cla-bot bot commented Jun 23, 2022

rigor789 left a comment

Choose a reason for hiding this comment

rigor789 Jun 23, 2022

Choose a reason for hiding this comment

rigor789 Jun 23, 2022

Choose a reason for hiding this comment

rigor789 Jun 23, 2022

Choose a reason for hiding this comment

Ombuweb Jun 24, 2022

Choose a reason for hiding this comment

cla-bot bot commented Jun 24, 2022

cla-bot bot commented Jul 8, 2022

cla-bot bot commented Jul 8, 2022

cla-bot bot commented Aug 13, 2022

cla-bot bot commented Aug 14, 2022

cla-bot bot commented Sep 19, 2022

cla-bot bot commented Oct 4, 2022

Ombuweb left a comment

Choose a reason for hiding this comment

cla-bot bot commented Oct 5, 2022

cla-bot bot commented Oct 5, 2022

cla-bot bot commented Oct 17, 2022

cla-bot bot commented Oct 18, 2022

cla-bot bot commented Oct 18, 2022

cla-bot bot commented Oct 18, 2022

cla-bot bot commented Oct 19, 2022

cla-bot bot commented Oct 26, 2022