Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gradle 8, kotlin 2.0 #1812

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

feat: gradle 8, kotlin 2.0 #1812

wants to merge 44 commits into from

Conversation

triniwiz
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla: yes label Apr 15, 2024
@triniwiz
Copy link
Member Author

Adds the following

  • Gradle 8
  • kotlin 2.0
  • java 17
  • kotlin enabled by default

@triniwiz triniwiz marked this pull request as ready for review April 16, 2024 09:24
Comment on lines +190 to +191
compileSdk computeCompileSdkVersion()
buildToolsVersion = computeBuildToolsVersion()

This comment was marked as outdated.

@ammarahm-ed
Copy link
Sponsor Contributor

Hey @triniwiz, we need this too in app/build.gradle before tasks.configureEach

rootProject.subprojects.forEach {
  it.tasks.configureEach({ DefaultTask currentTask ->
    if (currentTask =~ /.+bundleLibCompileToJar.*/) {
      cleanupAllJars.dependsOn currentTask
    }
  })
}

This fixes this error with adding open-native since it adds subprojects alongside :app subproject.

Gradle detected a problem with the following location: '/Volumes/DataDrive/Projects/nativescript/open-native/packages/core/react-android/react/build/intermediates/compile_library_classes_jar/debug/bundleLibCompileToJarDebug/classes.jar'.
    
    Reason: Task ':app:cleanupAllJars' uses this output of task ':react:bundleLibCompileToJarDebug' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':react:bundleLibCompileToJarDebug' as an input of ':app:cleanupAllJars'.
      2. Declare an explicit dependency on ':react:bundleLibCompileToJarDebug' from ':app:cleanupAllJars' using Task#dependsOn.
      3. Declare an explicit dependency on ':react:bundleLibCompileToJarDebug' from ':app:cleanupAllJars' using Task#mustRunAfter.
    
    For more information, please refer to https://docs.gradle.org/8.4/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants