Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mockito 5 #503

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Mockito 5 #503

merged 1 commit into from
Jul 20, 2023

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Jun 21, 2023

needs #252

@dev-mlb dev-mlb added dependencies This updates a dependency version blocked Work or adoption is blocked by something else labels Jun 21, 2023
@dev-mlb dev-mlb added this to the v8.0.0 milestone Jun 21, 2023
@jpdahlke jpdahlke modified the milestones: v8.0.0, v8.0.0-M1 Jun 24, 2023
@dev-mlb dev-mlb marked this pull request as ready for review July 19, 2023 17:38
@cfkoehler cfkoehler self-requested a review July 20, 2023 13:50
@cfkoehler
Copy link
Collaborator

Rebase should fix the checks. No longer need to run against the java 8 version

cfkoehler
cfkoehler approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@cfkoehler cfkoehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears good to me.
Same count of test success/skipped
Dependency tree looks like I would expect.

@dev-mlb dev-mlb removed the blocked Work or adoption is blocked by something else label Jul 20, 2023
@jpdahlke jpdahlke merged commit 1116295 into NationalSecurityAgency:master Jul 20, 2023
9 of 10 checks passed
aL118 pushed a commit to aL118/emissary that referenced this pull request Aug 4, 2023
@dev-mlb @aL118
mockito 5.4.0 (NationalSecurityAgency#503)
5ae7eef
@dev-mlb dev-mlb deleted the mockito-5 branch August 14, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdahlke jpdahlke jpdahlke approved these changes

@cfkoehler cfkoehler cfkoehler approved these changes

Assignees
No one assigned
Labels
dependencies This updates a dependency version
Projects
None yet
Milestone
v8.0.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dev-mlb @cfkoehler @jpdahlke