1676 - Allow '+' in IBDO Form name #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivenflywheel
requested changes
Jun 20, 2023
| assertTrue(PayloadUtil.isValidForm("-_"), "Dash and underscore aren't considered valid"); | ||
| assertTrue(PayloadUtil.isValidForm("formName-(suffixInParens)"), "Parentheses aren't considered valid"); | ||
| assertTrue(PayloadUtil.isValidForm("formName-(application/xml)"), "Slash aren't considered valid"); | ||
| assertTrue(PayloadUtil.isValidForm(alphaLow), "Lower case alpha characters are valid"); |
There was a problem hiding this comment.
I think we should alter each messages in this test to more clearly indicate what the expected result is. The original and proposed messages are ambiguous regarding whether they're stating desired vs observed behavior, but we can take away the ambiguity:
Suggested change
| assertTrue(PayloadUtil.isValidForm(alphaLow), "Lower case alpha characters are valid"); | |
| assertTrue(PayloadUtil.isValidForm(alphaLow), "Lower case alpha characters are expected to be valid"); |
or
Suggested change
| assertTrue(PayloadUtil.isValidForm(alphaLow), "Lower case alpha characters are valid"); | |
| assertTrue(PayloadUtil.isValidForm(alphaLow), "Expected lower case alpha characters to be valid"); |
| assertFalse(PayloadUtil.isValidForm("."), "Dot isn't considered valid"); | ||
| assertFalse(PayloadUtil.isValidForm(" "), "Space isn't considered valid"); | ||
| assertTrue(PayloadUtil.isValidForm("+"), "Plus are valid"); |
There was a problem hiding this comment.
Suggested change
| assertTrue(PayloadUtil.isValidForm("+"), "Plus are valid"); | |
| assertTrue(PayloadUtil.isValidForm("+"), "'+' is expected to be a valid form character"); |
aL118
changed the title
|
Forgot to add closes #502 |
ldhardy
approved these changes
Jun 21, 2023
Maybe? Hard to interpret which message (no pun intended) they were meant to convey, which just increases the time it would take to investigate and resolve a future regression. |
drivenflywheel
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added + to the regex that checks if valid form name and updated unit test. Also updated some comments.