Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KeywordScanner case insensitive search #465

Merged
merged 2 commits into from
May 4, 2023
Merged

Fix KeywordScanner case insensitive search #465

merged 2 commits into from
May 4, 2023

Conversation

fbruton
Copy link
Collaborator

@fbruton fbruton commented Apr 19, 2023

No description provided.

drivenflywheel
drivenflywheel previously requested changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor simplification requested

src/main/java/emissary/util/search/KeywordScanner.java Show resolved Hide resolved
@fbruton fbruton force-pushed the keywordScanner-caseinsensitive-fix branch from 24300e0 to 20431ee Compare April 22, 2023 00:32
@arp-0984 arp-0984 self-requested a review April 27, 2023 13:34
@jpdahlke jpdahlke requested review from drivenflywheel and removed request for drivenflywheel April 27, 2023 20:37
@jpdahlke jpdahlke added this to the v7.18.0 milestone Apr 27, 2023
drivenflywheel
drivenflywheel approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpdahlke jpdahlke added the bug Something isn't working as intended label Apr 28, 2023
@jpdahlke jpdahlke merged commit 126f238 into NationalSecurityAgency:master May 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drivenflywheel drivenflywheel drivenflywheel approved these changes

@SemperFidelisTyrannosaurus SemperFidelisTyrannosaurus SemperFidelisTyrannosaurus approved these changes

@arp-0984 arp-0984 arp-0984 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as intended
Projects
None yet
Milestone
v7.18.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fbruton @drivenflywheel @SemperFidelisTyrannosaurus @arp-0984 @jpdahlke