Fix #GROUPBY duplicate counts with query model #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When query model mapping is applied to a document before grouping and aggregating, it is possible for multiple fields to be mapped to the same root model mapping with the same value, resulting in duplicate field-value pairings that were incorrectly included in grouping and aggregation. Ensure that duplicate field-value pairings are disregarded. Add tests to verify this and update documentation to include details about how model mapping affects the #GROUPBY function. Fixes #2360
foster33
reviewed
May 14, 2024
warehouse/query-core/src/test/java/datawave/query/transformer/GroupingTest.java
Outdated
Show resolved
Hide resolved
…GroupingTest.java Fix comment typo. Co-authored-by: foster33 <[email protected]>
apmoriarty
approved these changes
May 24, 2024
ivakegg
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When query model mapping is applied to a document before grouping and aggregating, it is possible for multiple fields to be mapped to the same root model mapping with the same value, resulting in duplicate field-value pairings that were incorrectly included in grouping and aggregation.
Ensure that duplicate field-value pairings are disregarded. Add tests to verify this and update documentation to include details about how model mapping affects the #GROUPBY function.
Fixes #2360