FIX: Fix failing reporting of errors when messages contained special …

…characters
NagVis · Jan 24, 2024 · 1beb669 · 1beb669
1 parent ea01458
commit 1beb669
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,4 +1,6 @@
 1.9.41
+Frontend:
+ * FIX: Fix failing reporting of errors when messages contained special characters
 
 1.9.40
 Core:

diff --git a/share/frontend/nagvis-js/classes/ViewError.php b/share/frontend/nagvis-js/classes/ViewError.php
@@ -35,8 +35,8 @@ private function errorPage($e) {
  js('frontendMessage({'.N
  .' "type" : "error",'.N
  .' "closable": false,'.N
- .' "title" : "'.l('Error').'",'.N
- .' "message" : "'.htmlentities($e->getMessage(), ENT_COMPAT, 'UTF-8').'"'.N
+ .' "title" : '.json_encode(l('Error')).','.N
+ .' "message" : '.json_encode(htmlentities($e->getMessage(), ENT_COMPAT, 'UTF-8')).N
  .'});');
  echo '</div>';