Inject additional libraries for full X11 functionality #548
Conversation
elezar
force-pushed
the
additional-graphics-libs
branch
from
35c3ccf
to
38d84c7
Compare
|
@ehfd I realized that I hadn't cleaned up the changes from #490 prior to merging them. I therefore had to revert them and created this PR to include all the relevant changes. @tux-rampage your commits in the #490 were not signed off and as such you're not included as an author here. Feel free to push some signed-off commits here. |
|
Separately, I see no issues and approve the code. |
This change updates X11 library detection to ensure that this works for a wider range of driver installations. Signed-off-by: Seungmin Kim <[email protected]> Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
additional-graphics-libs
branch
from
38d84c7
to
d2b036f
Compare
|
I think @tux-rampage might not have access to the branch.
This is the required string. |
Yes, I would suppose that they don't have access. @tux-rampage feel free to create a PR targetting this branch indicating that you sign-off your work. Or coinfirm that I can add the string myself. |
|
@elezar On a separate note, what would be the best way to detect the kernel driver version from inside the container, other than |
You mean the "RM_VERSION"? Here one would probably have to rely on an NVML call. |
|
@elezar I did a bit more exploring, and it seems like the RM_VERSION of WSL is similar, but almost always different to the https://download.nvidia.com/XFree86/Linux-x86_64/ driver download page. Having issues with provisioning the I'll open a new issue about this. |
|
Continuing in #563 |
|
@tux-rampage Could you possibly approve this PR and indicate that |
This adds a function to return a path as a path relative to the specified driver root. Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
This change updates X11 library detection to ensure that this works for a wider range of driver installations.
This includes the changes from #490