Fix matcher bug with blossom-ci #3382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the github.actor instead of string contains. Signed-off-by: Adnan Khan <[email protected]>
|
@rajeevsrao @samurdhikaru, any interest in fixing this, or should I just close the PR? |
|
@samurdhikaru please advise on next steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to bypass the first check for users approved to run the blossom CI by creating a username that is a partial match. Per GitHub documentation, if the search param in contains is a string, it returns true upon a partial match. https://docs.github.com/en/actions/learn-github-actions/expressions#contains
See #3063 for an example where I used an account that partially matched @samurdhikaru 's name.
The resulting workflow failed at the next check, so there isn't security impact (and why I am making a PR instead of disclosing privately). Updating the check to use an array will prevent someone from bypassing the actor check in this manner.