Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MoE EP rank when TP is set at the same time #9161

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix MoE EP rank when TP is set at the same time #9161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbac3e0
fix ep rank
gdengk May 10, 2024
e4d230e
Merge branch 'main' into gaod/moe/fix_nemo_ep_rank
gdengk May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo/collections/nlp/modules/common/megatron/megatron_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def fake_initialize_model_parallel(
if expert_model_parallel_size_ is not None and expert_model_parallel_size_ > 1:
for ranks in rank_generator.get_ranks('ep', independent_ep=True):
if rank in ranks:
expert_model_parallel_rank = list(ranks).index(rank) // tensor_model_parallel_size
expert_model_parallel_rank = list(ranks).index(rank)

# Build the pipeline model-parallel groups and embedding groups
# (first and last rank in each pipeline model-parallel group).
Expand Down