Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucketing duration bins: less optimal but instant init when not provided + fixes in estimation script #9157

Merged
merged 10 commits into from May 14, 2024

Conversation

pzelasko
Copy link
Collaborator

@pzelasko pzelasko commented May 9, 2024

What does this PR do ?

  • speed-up in training start when duration bins are not provided (we will assume uniform split to num_buckets - 1 bins over the span of [min_duration - max_duration])
  • scripts/speech_recognition/estimate_duration_bins.py
    • support more data input flags supported by NeMo training configs
    • a lot of fixes to various edge cases and excessive memory usage...
  • renamed missing_sampling_rate_ok option in LhotseDataLoadingConfig to metadata_only and broadened its scope to prevent the construction of an infinite iterator over data (there was no way to get a precise bin estimate in multi-dataset setups before)

Collection: ASR

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

…ded + fixes in estimation script

Signed-off-by: Piotr Żelasko <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
@github-actions github-actions bot added the common label May 9, 2024
Signed-off-by: Piotr Żelasko <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Thanks

@@ -127,7 +127,7 @@ def read_dataset_config(config) -> tuple[CutSet, bool]:
"shard_seed": config.shard_seed,
"text_field": config.text_field,
"lang_field": config.lang_field,
"missing_sampling_rate_ok": config.missing_sampling_rate_ok,
"metadata_only": config.metadata_only,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about backward compat? Will older models with this flag crash ?

@titu1994 titu1994 merged commit 93907f0 into main May 14, 2024
131 checks passed
@titu1994 titu1994 deleted the fix-estimate-duration-bins-3 branch May 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants